summaryrefslogtreecommitdiffstats
path: root/2023/talks/flat.md
diff options
context:
space:
mode:
Diffstat (limited to '2023/talks/flat.md')
-rw-r--r--2023/talks/flat.md38
1 files changed, 26 insertions, 12 deletions
diff --git a/2023/talks/flat.md b/2023/talks/flat.md
index bf579540..4cf53d5b 100644
--- a/2023/talks/flat.md
+++ b/2023/talks/flat.md
@@ -42,18 +42,32 @@ activities.
in Emacs core?
- A: About a 20-line patch.
- Q: Could you please share the code for copy and paste? Thx!
- - A: 
- - (defun flat-style(theme &rest args)
- -   (custom-set-faces
- -    `(mode-line
- -      ((t (:inherit mode-line
- -                    :box (:line-width ,mode-line-height :style
- flat-button)))) t)
- -    `(mode-line-inactive
- -      ((t (:inherit mode-line-inactive
- -                    :box (:line-width ,mode-line-height :style
- flat-button)))) t)))
- - (advice-add 'load-theme :after #'flat-style)
+ - A:
+
+ (defun flat-style (theme &rest args)
+ (custom-set-faces
+ `(mode-line
+ ((t (:inherit mode-line
+ :box (:line-width ,mode-line-height :style
+ flat-button)))) t)
+ `(mode-line-inactive
+ ((t (:inherit mode-line-inactive
+ :box (:line-width ,mode-line-height :style
+ flat-button)))) t)))
+ (advice-add 'load-theme :after #'flat-style)
+
+ - **Important change 2 years later.**
+ CHANGES IN EMACS MASTER make the code above CRASH. Emacs,
+ The new flat-style function uses set-face-attribute:
+
+ (defvar mode-line-height 8 "Size of the box arounf the mode line")
+ (defun flat-style (theme &rest _)
+ (set-face-attribute 'mode-line nil
+ :box (list :line-width mode-line-height :style 'flat-button))
+ (set-face-attribute 'mode-line-inactive nil
+ :box (list :line-width mode-line-height :style 'flat-button)))
+
+
- Q: Do you teach Emacs to any of your university students?
- A: No teaching, but a lot of introdcuing ;-)